Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/#6587 - Fix Search Funnel error when GA is in a gathering state #6606

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Bug/#6587 - Fix Search Funnel error when GA is in a gathering state #6606

merged 3 commits into from
Feb 21, 2023

Conversation

hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented Feb 17, 2023 •
edited by techanvil
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

github-actions bot commented Feb 17, 2023 •
edited
Loading

Size Change: +36 B (0%)

Total Size: 1.24 MB

Filename Size Change
./dist/assets/js/googlesitekit-modules-search-console-********************.js 40.3 kB +36 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 48.2 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.1 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.31 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-activation-********************.js 27.1 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 36.3 kB
./dist/assets/js/googlesitekit-api-********************.js 9.55 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.82 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 9.8 kB
./dist/assets/js/googlesitekit-data-********************.js 2.15 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.22 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 16.3 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.34 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 22.3 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 65 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 71 kB
./dist/assets/js/googlesitekit-modules-********************.js 20.2 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 70.5 kB
./dist/assets/js/googlesitekit-modules-analytics-********************.js 72.9 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 23.6 kB
./dist/assets/js/googlesitekit-modules-optimize-********************.js 18.8 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 21.1 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B
./dist/assets/js/googlesitekit-settings-********************.js 51.6 kB
./dist/assets/js/googlesitekit-splash-********************.js 70.1 kB
./dist/assets/js/googlesitekit-user-input-********************.js 44.5 kB
./dist/assets/js/googlesitekit-vendor-********************.js 332 kB
./dist/assets/js/googlesitekit-widgets-********************.js 16.1 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.7 kB
./dist/assets/js/runtime-********************.js 1.26 kB

compressed-size-action

techanvil
techanvil requested changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @hussain-t, just one very minor comment from me.

assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/Overview/index.js Outdated
Comment on lines 100 to 102
analyticsModuleConnected
? select( MODULES_ANALYTICS ).isGatheringData()
: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a minor point, but this could be marginally simplified by using logical AND here instead:

Suggested change
analyticsModuleConnected
? select( MODULES_ANALYTICS ).isGatheringData()
: false
analyticsModuleConnected && select( MODULES_ANALYTICS ).isGatheringData()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated 👍

techanvil
techanvil approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one @hussain-t!

@techanvil techanvil merged commit 9ef6a69 into develop Feb 21, 2023
@techanvil techanvil deleted the bug/#6587-gathering-data-search-funnel branch February 21, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techanvil techanvil techanvil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hussain-t @techanvil